Feat: add more tests

handlers/api/getImages.go

@@ -1,16 +1,21 @@
 package api
 
 import (
+	"fmt"
 	"net/http"
+	"slices"
 	"strconv"
 	"strings"
 
 	"gitea.konchin.com/go2025/backend/middlewares"
+	"gitea.konchin.com/go2025/backend/tracing"
 	"github.com/uptrace/bunrouter"
+	"go.uber.org/zap"
 )
 
 type getImagesOutputImage struct {
 	Id         int64   `json:"id"`
+	Extension  string  `json:"extension"`
 	Uploader   string  `json:"uploadedUserId"`
 	UploadTS   int64   `json:"uploadedAt"`
 	AliasesIds []int64 `json:"aliasesIds"`
@@ -29,11 +34,18 @@ func (self *Handlers) GetImages(
 ) error {
 	ctx := req.Context()
 
+	rmf := func(s string) bool { return len(s) == 0 }
 	rawReqImages := strings.Split(req.URL.Query().Get("images"), ",")
+	rawReqImages = slices.DeleteFunc(rawReqImages, rmf)
 	rawReqAliases := strings.Split(req.URL.Query().Get("aliases"), ",")
+	rawReqAliases = slices.DeleteFunc(rawReqAliases, rmf)
 
 	if (len(rawReqImages) == 0 && len(rawReqAliases) == 0) ||
 		(len(rawReqImages) > 0 && len(rawReqAliases) > 0) {
+		tracing.Logger.Ctx(ctx).
+			Debug("rawReq",
+				zap.String("rawReqImages", fmt.Sprintf("%+v", rawReqImages)),
+				zap.String("rawReqAlias", fmt.Sprintf("%+v", rawReqAliases)))
 		return middlewares.HTTPError{
 			StatusCode: http.StatusBadRequest,
 			Message:    "images and aliases should exist exactly one",
@@ -79,6 +91,7 @@ func (self *Handlers) GetImages(
 		}
 		output = append(output, getImagesOutputImage{
 			Id:         img.Id,
+			Extension:  img.Extension,
 			Uploader:   img.Uploader,
 			UploadTS:   img.UploadTS.Unix(),
 			AliasesIds: aliases,

handlers/api/postImage.go

@@ -8,17 +8,23 @@ import (
 	"gitea.konchin.com/go2025/backend/middlewares"
 	"gitea.konchin.com/go2025/backend/models"
 	"gitea.konchin.com/go2025/backend/types"
-	"gitea.konchin.com/go2025/backend/utils"
 	"github.com/uptrace/bunrouter"
 )
 
+type postImageOutput struct {
+	Id        int64     `json:"id"`
+	Extension string    `json:"extension"`
+	Uploader  string    `json:"uploadedUserId"`
+	UploadTS  time.Time `json:"uploadedAt"`
+}
+
 // PostImage
 //
 //	@param		userinfo	header string true	"userinfo from /auth/gen-login-url"
 //	@accept		image/png
 //	@accept		image/jpeg
 //	@accept		image/gif
-//	@success	200
+//	@success	200 {object} postImageOutput
 //	@failure	401
 //	@router		/api/image [post]
 func (self *Handlers) PostImage(
@@ -65,5 +71,10 @@ func (self *Handlers) PostImage(
 			OriginError: err,
 		}
 	}
-	return utils.Success(w)
+	return bunrouter.JSON(w, postImageOutput{
+		Id:        image.Id,
+		Extension: image.Extension,
+		Uploader:  image.Uploader,
+		UploadTS:  image.UploadTS,
+	})
 }